-
- Downloads
Merging r369760:
------------------------------------------------------------------------ r369760 | szelethus | 2019-08-23 16:21:13 +0200 (Fri, 23 Aug 2019) | 13 lines [analyzer] Avoid unnecessary enum range check on LValueToRValue casts Summary: EnumCastOutOfRangeChecker should not perform enum range checks on LValueToRValue casts, since this type of cast does not actually change the underlying type. Performing the unnecessary check actually triggered an assertion failure deeper in EnumCastOutOfRange for certain input (which is captured in the accompanying test code). Reviewers: #clang, Szelethus, gamesh411, NoQ Reviewed By: Szelethus, gamesh411, NoQ Subscribers: NoQ, gamesh411, xazax.hun, baloghadamsoftware, szepet, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, Charusso, bjope, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D66014 ------------------------------------------------------------------------ llvm-svn: 371058
Showing
- clang/lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp 16 additions, 0 deletions...lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp
- clang/test/Analysis/enum-cast-out-of-range.c 34 additions, 0 deletionsclang/test/Analysis/enum-cast-out-of-range.c
- clang/test/Analysis/enum-cast-out-of-range.cpp 9 additions, 1 deletionclang/test/Analysis/enum-cast-out-of-range.cpp
Loading
Please register or sign in to comment